Forum ‹ C# ‹ Room active with no connections

[azuanagames]

I'm currently in the middle of debugging new server and client code, so I have the development server running in the debugger. I had mentioned before that I was witnessing rooms that had no players in them continue to run. Well I was just able to replicate it on the development server. PlayerCount is 0, yet timers continue to fire.

Could this be my fault for not killing a timer? Or should those timers die on their own once PlayerCount hits 0?

I can't reproduce the error on demand. It may have to do with a disconnect while joining the room.

P.S. It won't help right now because they won't be there when you check, but, I have 3 rooms active with no players in them...

[azuanagames]

Ok, I can reproduce this 100%...

I have the online status of a player in BigDB. When a user joins I check if they are already in a room using BigDB in the AllowUserJoin function.

If I connect twice, the second connection gets kicked off due to the above check. Once that happens the server is in crazy mode. I manually disconnect the first client. Then I wait a bit and the server shows no players on but the game is never closed.

I then re-connect and the game is already running. I don't seem to get a UserJoined event. (I have to verify this, I have an init message that gets sent in UserJoined, but I'm seeing other messages come before the init. Which causes a crash in my client, since it expects init first.)

Another sure fire way to make the server get stuck is to simply return false from AllowUserJoin. The room stays open and doesn't close when the player is kicked off.

Will report more as I try to figure out the problem.

[Oliver]

Hey, that sounds absolutely crazy.

Could you send us the project you're using, or a smaller test-case we can use to fix the issue?
If you're feeling particularly helpful, a small screen cast of you deliberately causing the issue would be very helpful

Best,
Oliver

[azuanagames]

I'll try to reproduce this in a smaller example and will send it to you.

I was mistaken about never getting the UserJoin event, I am getting the UserJoin. But the server definitely gets stuck open when I return false from the AllowUserJoin.

Hope to have something for you to look at soon.

[azuanagames]

Add the following code to your tic-tac-toe example

Code: Select all

    public override bool AllowUserJoin(Player player)
    {
      foreach (Player p in Players) {
        if (p.ConnectUserId == player.ConnectUserId) {
          return false;
        }
      }
      return true;
    }


Now connect with the same connect id, like Whatever-3232 and Whatever-3232 and join the same room. Once you get kicked off, close both clients. The server will still be running the room.

[Oliver]

Hey,

Thanks for the great error report! It really makes it much easier to find and fix issues when they're this easy to reproduce.

We reproduced the error with no problem, and have implemented a fix for it, that will be available in the next release.

Best,
Oliver

[azuanagames]

Out of curiosity is this bug also responsible for servers staying open for no apparent reason? I mean because of a user disconnect or some other reason not associated to the AllowUserJoin method?

[Oliver]

Hmm... i don't think so. this was an issue directly related to the use of AllowUserJoin method.

[azuanagames]

Alright. I'll have to look at my other server. That server has open rooms all the time and I don't use AllowUserJoin. It has 2 rooms right now with no one in them.

There is however a bug in that server that is in the ErrorLog. null pointer usage. I'm fairly certain it has to do with that error.

[Oliver]

Paste the null error message here ?

- Oliver

[azuanagames]

Object reference not set to an instance of an object.

First seen 6 days ago, latest 17 hours ago. (delete 17 errors)

Like I've said before, I'm not so sure where to look for this. More than likely it's my bug, since my FB version doesn't give this error at all.

[Oliver]

Oh, i was hoping for a stacktrace

[azuanagames]

Me too!